basic auth with base64 username:password should be labelled Basic, no…

…t Bearer
nodejs · Apr 11, 2024 · 11419a2 · 11419a2
1 parent 4672162
commit 11419a2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/sources/httpUtils.ts b/sources/httpUtils.ts
@@ -20,7 +20,7 @@ async function fetch(input: string | URL, init?: RequestInit) {
  if (username || password) {
  headers = {
  ...headers,
- authorization: `Bearer ${Buffer.from(`${username}:${password}`).toString(`base64`)}`,
+ authorization: `Basic ${Buffer.from(`${username}:${password}`).toString(`base64`)}`,
  };
  input.username = input.password = ``;
  } else if (input.origin === process.env.COREPACK_NPM_REGISTRY || DEFAULT_NPM_REGISTRY_URL) {
@@ -32,7 +32,7 @@ async function fetch(input: string | URL, init?: RequestInit) {
  } else if (`COREPACK_NPM_PASSWORD` in process.env) {
  headers = {
  ...headers,
- authorization: `Bearer ${Buffer.from(`${process.env.COREPACK_NPM_USER}:${process.env.COREPACK_NPM_PASSWORD}`).toString(`base64`)}`,
+ authorization: `Basic ${Buffer.from(`${process.env.COREPACK_NPM_USER}:${process.env.COREPACK_NPM_PASSWORD}`).toString(`base64`)}`,
  };
  }
  }

diff --git a/tests/_registryServer.mjs b/tests/_registryServer.mjs
@@ -66,7 +66,7 @@ function generateVersionMetadata(packageName, version) {
 
 const server = createServer((req, res) => {
  const auth = req.headers.authorization;
- if (!auth?.startsWith(`Bearer `) || Buffer.from(auth.slice(`Bearer `.length), `base64`).toString() !== `user:pass`) {
+ if (!auth?.startsWith(`Bearer `) || Buffer.from(auth.slice(`Basic `.length), `base64`).toString() !== `user:pass`) {
  res.writeHead(401).end(`Unauthorized`);
  return;
  }