Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle package managers with a bin array correctly #20

Merged
merged 3 commits into from
Sep 30, 2020
Merged

fix: handle package managers with a bin array correctly #20

merged 3 commits into from
Sep 30, 2020

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Sep 30, 2020

What's the problem this PR addresses?

In #13 I broke running the yarnpkg command because I didn't handle the array correctly

How did you fix it?

Handle package managers with an "array bin field" correctly, by doing the same parsing in pmmUtils.runVersion as in pmmUtils.installVersion

@arcanis arcanis merged commit 1836d17 into nodejs:main Sep 30, 2020
@merceyz merceyz deleted the merceyz/bin-arrays branch September 30, 2020 22:49
@github-actions github-actions bot mentioned this pull request Jun 11, 2022
Merged
@arcanis arcanis mentioned this pull request Jun 13, 2022
Merged
Uzomahopeujunwa
Uzomahopeujunwa reviewed Nov 15, 2023
View reviewed changes
Copy link

@Uzomahopeujunwa Uzomahopeujunwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzomahopeujunwa Uzomahopeujunwa Uzomahopeujunwa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merceyz @Uzomahopeujunwa @arcanis