chore: remove vm2 from dev dependencies
#284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hum it seems that 3.9.19 is also affected, so that won't fix the automated report 😒 https://www.npmjs.com/package/vm2 shows that the package is deprecated and won't be fixed, so let's remove it from our dependency tree instead. |
aduh95
changed the title
vm2 dev dependencyvm2 from dev dependencies
|
It seems it's not possible to affect dependencies using patches, @arcanis is that right? I'd have sworn that was possible at some point. |
|
Metadata are retrieved from the registry, so I think patch won't be able to change them; probably something we should fix in Yarn 🤔 In the meantime we can use a |
aduh95
commented
Jul 14, 2023
merceyz
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vm2 is a transitive dependency that we do not use, and we patched it to be completely harmless. However, it seems the automation is not able to detect that, and is producing annoying warnings, so let's update it.
Refs: #283