Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check that a semver version is required #312

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Oct 8, 2023

Adds a test to ensure that not specifying a semver version in package.json#packageManager isn't allowed.
Ref #300 (review).

@merceyz merceyz force-pushed the merceyz/test/version-required branch from eff613a to 00a0dc4 Compare October 8, 2023 14:37
@rotu
Copy link

rotu commented Oct 8, 2023

How does this work with package managers that use non-semver versioning or for package specifiers like npm@github:npm/cli#c12ea07 or yarn@https://registry.npmjs.org/yarn/-/yarn-2.4.3.tgz?

@merceyz
Copy link
Member Author

merceyz commented Oct 8, 2023

It doesn't, neither of those are supported.
Note that this PR doesn't change the behaviour of Corepack, it merely tests existing behaviour.

@merceyz merceyz merged commit 2533d12 into nodejs:main Oct 8, 2023
7 checks passed
@merceyz merceyz deleted the merceyz/test/version-required branch October 8, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants