-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use fetch
#365
feat!: use fetch
#365
Conversation
7c68851
to
70c842c
Compare
Worth noting: nock just added support for |
d3e6ca6
to
0643456
Compare
@aduh95 any suggestions for how to debug the Windows issue? I've tried storing body as a Buffer and Uint8Array and it throws |
I was able to reproduce the ci failure on my machine. This patch fixed it for me: |
I can confirm @stduhpf findings 👍 |
|
Yeah, I already tried using an |
Yeah but what’s weird is that we were able to reproduce the failure of 0643456 but on later commits, the tests pass locally with |
d49f071
to
c345721
Compare
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
This reverts commit 5163ee8.
Changes Corepack to use the built-in
fetch
and theProxyAgent
from Undici.Since
fetch
supports compressed responses by default the bandwidth used when fetching fromhttps://repo.yarnpkg.com/tags
is also reduced (Transferred 1.71 kB (5.46 kB size)
.Closes #361
FIxes #293
BREAKING CHANGE:
Corepack is now using the built-in
fetch
method and theProxyAgent
from Undici to perform requests, setups using custom registries and/or proxies might be affected.