Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: download only yarn.js from npm #439

Merged
merged 21 commits into from
Apr 1, 2024
Merged

Conversation

zhyupe
Copy link
Contributor

@zhyupe zhyupe commented Mar 25, 2024

Added bin property to NpmRegistrySpec. When installing yarn berry from custom registry, it'll only install the bin file and calculate hash of the bin file itself.

Fix #435

@aduh95
Copy link
Contributor

aduh95 commented Mar 25, 2024

Have you considered using filter option of tar.x?

sources/corepackUtils.ts Outdated Show resolved Hide resolved
sources/corepackUtils.ts Outdated Show resolved Hide resolved
sources/corepackUtils.ts Outdated Show resolved Hide resolved
zhyupe and others added 4 commits March 26, 2024 11:01
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
sources/corepackUtils.ts Outdated Show resolved Hide resolved
sources/corepackUtils.ts Outdated Show resolved Hide resolved
Co-authored-by: Maël Nison <nison.mael@gmail.com>
sources/corepackUtils.ts Outdated Show resolved Hide resolved
sources/corepackUtils.ts Outdated Show resolved Hide resolved
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
sources/corepackUtils.ts Outdated Show resolved Hide resolved
sources/corepackUtils.ts Outdated Show resolved Hide resolved
@aduh95
Copy link
Contributor

aduh95 commented Mar 26, 2024

Other than tests, is there something else to be done before this can be marked as ready for reviews?

@zhyupe
Copy link
Contributor Author

zhyupe commented Mar 26, 2024

Other than tests, is there something else to be done before this can be marked as ready for reviews?

No, I think. But I'm experiencing some networking problems and have little time resolving it. So may be it will be ready in 1-2 days.

@zhyupe zhyupe marked this pull request as ready for review March 26, 2024 16:31
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
tests/main.test.ts Outdated Show resolved Hide resolved
zhyupe and others added 3 commits March 28, 2024 00:06
@zhyupe
Copy link
Contributor Author

zhyupe commented Mar 29, 2024

@aduh95 Waiting for #445 being merged or the tests would fail

@aduh95 aduh95 merged commit 4672162 into nodejs:main Apr 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash validation failed for yarn when COREPACK_NPM_REGISTRY is set on one side
3 participants