Don't resolve default version when project version is specified, and don't make error if fetching from remote fails #626
+31
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should land this as is, IMO folks who want Corepack to default to latest would be deceived with Corepack silently falling back to a non-latest. |
|
I've reverted d1e3957, silent fallback to non-latest, since it was not main focus of this PR. I may make separate PR with env var flag later. |
|
Oh well, I was working on that in #632 |
anatawa12
deleted the
dont-resolve-default-version-when-project-version-is-specified
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements my suggestion in #625.
Closes #625