-
-
Notifications
You must be signed in to change notification settings - Fork 44
feat(cli): add support for dry-run, verbose #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds CLI support for dry-run and verbose modes to the meeting artifacts creation tool using Commander.js. It enables users to preview what would be created without making actual changes and provides detailed debug output.
Key changes:
- Refactored configuration system to support CLI options alongside environment variables
- Added dry-run mode that prevents actual creation of GitHub issues and HackMD documents
- Integrated verbose logging for GitHub API operations
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
create-node-meeting-artifacts.mjs | Added Commander.js CLI parsing and dry-run logic for conditional resource creation |
src/config.mjs | Converted from function-based to object-based configuration export |
src/github.mjs | Added verbose logging support to GitHub client creation |
package.json | Added Commander.js dependency |
.github/workflows/*.yml | Updated workflow commands to use new CLI options |
test/config.test.mjs | Removed existing configuration tests (requires new test approach) |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 9 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cc @ovflowd |
8e5e29a
to
433dffa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 9 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Ref: #186
This PR uses Commander to add:
--dry-run
(Run w/o creating any notes or issues)--verbose
(Run w/ verbose Octokit)