-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add up to date documentation for AsyncWrap #27
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1c08607
docs: add up to date documentation for AsyncWrap
AndreasMadsen 35362dc
docs: incorporate Trevis comments into the AsyncWrap documentation
AndreasMadsen ffcaa9f
docs: minor spelling corrections, thanks Stephen
AndreasMadsen f327509
docs: mostly gramma and a remark about Promises
AndreasMadsen c7244e0
docs: fix long lines and a single comma
AndreasMadsen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
'use strict'; | ||
|
||
const fs = require('fs'); | ||
const net = require('net'); | ||
const getStack = require('./example-trace.js'); | ||
|
||
Error.stackTraceLimit = Infinity; | ||
|
||
const server = net.createServer(function (socket) { | ||
|
||
fs.open(__filename, 'r', function (err, fd) { | ||
if (err) throw err; | ||
|
||
fs.close(fd, function (err) { | ||
if (err) throw err; | ||
|
||
console.log(getStack('trace')); | ||
socket.end('hallo world'); | ||
}); | ||
}) | ||
}); | ||
|
||
server.listen(0, 'localhost', function () { | ||
const addr = server.address(); | ||
const socket = net.connect(addr.port, addr.address, function () { | ||
socket.once('readable', function () { | ||
socket.read(); | ||
socket.once('readable', server.close.bind(server)); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
'use strict'; | ||
|
||
const asyncWrap = process.binding('async_wrap'); | ||
|
||
asyncWrap.setupHooks(init, before, after); | ||
asyncWrap.enable(); | ||
|
||
// global state variable, that contains the current stack trace | ||
let currentStack = ''; | ||
|
||
function init(provider, parent) { | ||
// When a handle is created, collect the stack trace such that we later | ||
// can see what involved the handle constructor. | ||
const localStack = (new Error()).stack.split('\n').slice(1).join('\n'); | ||
|
||
// Compute the full stack and store it as a property on the handle object, | ||
// such that it can be fetched later. | ||
const extraStack = parent ? parent._full_init_stack : currentStack; | ||
this._full_init_stack = localStack + '\n' + extraStack; | ||
} | ||
function before() { | ||
// A callback is about to be called, update the `currentStack` such that | ||
// it is correct for when another handle is initialized or `getStack` is called. | ||
currentStack = this._full_init_stack; | ||
} | ||
function after() { | ||
// At the time of writing there are some odd cases where there is no handle | ||
// context, this line prevents that from resulting in wrong stack trace. But | ||
// the stack trace will be shorter compared to what ideally should happen. | ||
currentStack = ''; | ||
} | ||
|
||
function getStack(message) { | ||
const localStack = new Error(message); | ||
return localStack.stack + '\n' + currentStack; | ||
} | ||
module.exports = getStack; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as off-topic.
Sorry, something went wrong.