Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add minutes for meeting jan 25, 2022 #524

Closed
wants to merge 1 commit into from
Closed

doc: add minutes for meeting jan 25, 2022 #524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions wg-meetings/2022-01-25.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
# Node.js Diagnostics WorkGroup Meeting 2022-01-25

## Links

* **Recording**: https://www.youtube.com/watch?v=qfJP3C3sGwI
* **GitHub Issue**: https://github.com/nodejs/diagnostics/issues/523
* **Minutes Google Doc**: https://docs.google.com/document/d/1vwNhdIsHfBj4AtoSSzBjsv89Hxgqbv7flTT2jrDMHmE/edit

## Present

* Diagnostics team: @nodejs/diagnostics
* Rafael Gonzaga: @rafaelgss
* Bradley Farias: @bmeck
* Stephen Belanger: @qard
* Gireesh Punathil: @gireeshpunathil
* Tony Gorez: @tony-go

## Agenda

## Announcements

*Extracted from **diag-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.

### nodejs/diagnostics

* Add using clinic/heap-profiler step [#521](https://github.com/nodejs/diagnostics/issues/521)
- rafael: the issue is opened to discuss possibility of recommending clinic/heap-profiler in our docs
- gireesh: we have incorporated many third party tools in the past, so should not be an issue
- bradley: license agreements in 3rd party tools is what makes it problematic.
- third-party tool can be recommended only if it is open-source licensed (MIT).
- all: agree.
* Document async_hooks types purposes [#511](https://github.com/nodejs/diagnostics/issues/511)
- rafael: some async_hook resource types are underdocumented / undocumented
- bradley: properties are not supposed to be stable, and they can change types based on future changes. it is ok to document those, but needs some tests to make sure they are always in sync with the code changes.
- stephen: personally prefer to be explicit in the doc about what the type of a resource is and what it can hold, in reality.
- tony: is there a tool that synchronizes the code and the doc?
- stephen: it is not practical; there could be more subjective things to add in the doc such as API contract versus an arbitrary type, so prefer manual updates.
- rafael: going to update the issue, follow the suggestions, and remove from the agenda.

* meeting time, again [#507](https://github.com/nodejs/diagnostics/issues/507)
- gireesh: bradley, pls update your preferences in doodle, we will visit it in the next meeting once all preferences are in place.

* User Journey tracking documentation [#502](https://github.com/nodejs/diagnostics/issues/502)
- rafel: just an information on the tweet that we just realized. Tony is here because of that. the label can be removed and progress can be made on the documentation work.

* Identify async_hooks use cases beyond AsyncLocalStorage [#437](https://github.com/nodejs/diagnostics/issues/437)
- stephen: there wasn't any movement on this, take off the agenda.


## Q&A, Other

## Upcoming Meetings

* **Node.js Foundation Calendar**: <https://nodejs.org/calendar>

Click `+GoogleCalendar` at the bottom right to add to your own Google calendar.