Skip to content
This repository has been archived by the owner on Jul 20, 2018. It is now read-only.

Upgrade to 1.4.3 #34

Merged
merged 1 commit into from
Mar 6, 2015
Merged

Upgrade to 1.4.3 #34

merged 1 commit into from
Mar 6, 2015

Conversation

hmalphettes
Copy link
Member

It looks so trivial: let me know if I missed something.

@Starefossen
Copy link
Member

LGTM

@Starefossen
Copy link
Member

@hmalphettes This should maybe be documented better, but when this is merged someone must create a PR to the official docker image registry for io.js in order for this to be available on the Docker Hub.

@pesho
Copy link
Contributor

pesho commented Mar 6, 2015

LGTM, thanks @hmalphettes. I held off on this, because the changes in 1.4.2 and 1.4.3 are Windows-specific (don't matter in Docker), plus an NPM upgrade (which only matters in interactive usage).

pesho added a commit that referenced this pull request Mar 6, 2015
@pesho pesho merged commit de55282 into nodejs:master Mar 6, 2015
@pesho
Copy link
Contributor

pesho commented Mar 6, 2015

@Starefossen it is documented here, in the wiki: https://github.com/iojs/docker-iojs/wiki/Updating-versions

@hmalphettes can you please also send the PR which @Starefossen mentioned (step 5 from the instructions in the wiki)

@Starefossen
Copy link
Member

Starefossen commented Mar 6, 2015 via email

@hmalphettes
Copy link
Member Author

@pesho @Starefossen thanks for kindly pointing to the documentation.
I'll try this with 1.5 that has just shipped.

@pesho
Copy link
Contributor

pesho commented Mar 7, 2015

@hmalphettes already done - #35 :) (but I don't think the Docker folks will merge the Hub PR before Monday)

@hmalphettes
Copy link
Member Author

@pesho cheers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants