Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two new release team members #924

Closed
MylesBorins opened this issue Nov 21, 2018 · 7 comments
Closed

Two new release team members #924

MylesBorins opened this issue Nov 21, 2018 · 7 comments

Comments

@MylesBorins
Copy link
Contributor

Ruben Bridgewater ruben@bridgewater.de A48C2BEE680E841632CD4E44F07496B3EB3C1762
Beth Griggs bethany.griggs@uk.ibm.com 4ED778F539E3634C779C87C6D7062848A1AB005C
@SimenB
Copy link
Member

SimenB commented Nov 21, 2018

Mind updating https://github.com/nodejs/docker-node/blob/master/keys/node.keys?

MylesBorins added a commit to MylesBorins/docker-node that referenced this issue Nov 21, 2018
@MylesBorins
keys: add new keys and remove old keys
a7b5c94 
Added New Releasers:

* Beth Griggs
  - bethany.griggs@uk.ibm.com
  - 4ED778F539E3634C779C87C6D7062848A1AB005C
* Ruben Bridgewater
  - ruben@bridgewater.de
  - A48C2BEE680E841632CD4E44F07496B3EB3C1762

Removed Emeritus Releaser:

* Italo A. Casas
  - me@italoacasas.com
  - 56730D5401028683275BD23C23EFEFE93C4CFFFE

Closes: nodejs#924
@MylesBorins MylesBorins mentioned this issue Nov 21, 2018
Merged
@MylesBorins
Copy link
Contributor Author

@SimenB done

@SimenB
Copy link
Member

SimenB commented Nov 21, 2018 •
edited
Loading

@MylesBorins is there some document that mandates an issue in this repo for new releasers? If so, maybe update it to just send a PR instead?

@chorrell
Copy link
Contributor

For reference (the changes to the release keys)

@SimenB
Copy link
Member

SimenB commented Nov 21, 2018

Best would be if this was in some document on nodejs.org that we could pull down in our update.sh script

@PeterDaveHello
Copy link
Member

@SimenB https://github.com/nodejs/node#release-team

@MylesBorins
Copy link
Contributor Author

@SimenB --> https://github.com/nodejs/Release/blob/master/GOVERNANCE.md#adding-new-releasers
We are updating the text right now and I suggested changing it to be a PR

nodejs/Release#393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chorrell @MylesBorins @SimenB @PeterDaveHello