Skip to content

Update to 17.7.0 #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update to 17.7.0 #1662

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

Automated changes by create-pull-request GitHub action

@tianon
Copy link
Contributor

tianon commented Mar 10, 2022

Instead of just borrowing the credentials of whoever made the last commit, shouldn't this instead use a static value for the commit author? Perhaps an email address associated with @nodejs-github-bot would be appropriate?

@nschonni nschonni mentioned this pull request Mar 10, 2022
@PeterDaveHello
Copy link
Member

Should better use another identity like @nodejs-github-bot 👍

BTW, v17.7.1 released: https://nodejs.org/en/blog/release/v17.7.1, should we skip 17.7.0?

@SimenB
Copy link
Member

SimenB commented Mar 11, 2022

This is 17.7.1, it just has the wrong title

@nschonni
Copy link
Member

merged the manual PR, so we'll see how this one changes

@SimenB
Copy link
Member

SimenB commented Mar 11, 2022

So commit message and PR title is wrong - they both use the same output. Weird the author is wrong, but we can probably just set that manually

@PeterDaveHello
Copy link
Member

Okay, it's 17.7.1, and also touched too much diff. As #1663 was merged, let's close this one.

@PeterDaveHello PeterDaveHello deleted the update-branch branch March 11, 2022 06:21
@SimenB
Copy link
Member

SimenB commented Mar 11, 2022

Let's keep it open to verify the bot closes it on its own

@SimenB SimenB restored the update-branch branch March 11, 2022 06:25
@SimenB SimenB reopened this Mar 11, 2022
@SimenB
Copy link
Member

SimenB commented Mar 11, 2022

Also, did anyone see if it created tests? I see it does now, but that retriggered when I restored the branch. Original status checks are gone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants