Skip to content

Conversation

@nschonni
Copy link
Member

@nschonni nschonni commented Jun 2, 2022

Description

Motivation and Context

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Others (non of above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@nschonni
Copy link
Member Author

nschonni commented Jun 2, 2022

@nodejs/releasers looks like the 17.9.1 https://unofficial-builds.nodejs.org/download/release/v17.9.1/ artifacts didn't get promoted

@ruyadorno
Copy link
Member

Interesting, I validated the promotion worked by looking up: https://nodejs.org/dist/v17.9.1/ (as directed per our doc/contributing/releases.md guide) @nodejs/releasers maybe we should add another step / check to the release guide?

Also, what is the best way to possibly fix this? run ./tools/release.sh again?

@targos
Copy link
Member

targos commented Jun 2, 2022

I don't know how unofficial builds are promoted, but I'm pretty sure it's not the job of @nodejs/releasers

@nschonni
Copy link
Member Author

nschonni commented Jun 2, 2022

You're right that the unofficial images isn't a problem for the Release folks. The non-apline releases that don't rely on the unofficial builds are also failing. My original hunch was a signing key mismatch, but the unofficial build logs have a different error that it's failing to get the tar https://unofficial-builds.nodejs.org/logs/202206020213-v17.9.1/fetch-source.log
I'll try and reset the build here to see if it was just another cloudflare CDN issue

@nschonni
Copy link
Member Author

nschonni commented Jun 2, 2022

Actually, I'm thinking the failure is from trying to download https://nodejs.org/dist/v17.19.1/SHASUMS256.txt.asc
It looks like it only has the txt file, and not the usual three:
SHASUMS256.txt
SHASUMS256.txt.asc
SHASUMS256.txt.sig

@ruyadorno
Copy link
Member

Personally I think I might have hit a problem during my release, those missing SHASUM files do ring a bell since this release was also the first time I had a problem generating the blog post in which I had to copy/paste the SHASUM manually from the output of the promotion commands.

I tried running again the commands to copy over the missing files, let me know if that worked @nschonni

@nschonni
Copy link
Member Author

nschonni commented Jun 2, 2022

@ruyadorno the extra files looked like it fixed it! I'm going to flip this to draft while the separate unofficial builds is resolved.

@nschonni nschonni marked this pull request as draft June 2, 2022 18:03
@nschonni nschonni marked this pull request as ready for review June 4, 2022 02:25
@nschonni nschonni requested a review from a team June 4, 2022 02:25
@github-actions
Copy link

github-actions bot commented Jun 4, 2022

Created PR on the official-images repo (docker-library/official-images#12581). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

@nschonni nschonni deleted the june-2022 branch June 4, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants