-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: Node.js 16.15.1, 17.9.1, and 18.3.0 #1731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@nodejs/releasers looks like the 17.9.1 https://unofficial-builds.nodejs.org/download/release/v17.9.1/ artifacts didn't get promoted |
|
Interesting, I validated the promotion worked by looking up: https://nodejs.org/dist/v17.9.1/ (as directed per our Also, what is the best way to possibly fix this? run |
|
I don't know how unofficial builds are promoted, but I'm pretty sure it's not the job of @nodejs/releasers |
|
You're right that the unofficial images isn't a problem for the Release folks. The non-apline releases that don't rely on the unofficial builds are also failing. My original hunch was a signing key mismatch, but the unofficial build logs have a different error that it's failing to get the tar https://unofficial-builds.nodejs.org/logs/202206020213-v17.9.1/fetch-source.log |
|
Actually, I'm thinking the failure is from trying to download |
|
Personally I think I might have hit a problem during my release, those missing SHASUM files do ring a bell since this release was also the first time I had a problem generating the blog post in which I had to copy/paste the SHASUM manually from the output of the promotion commands. I tried running again the commands to copy over the missing files, let me know if that worked @nschonni |
|
@ruyadorno the extra files looked like it fixed it! I'm going to flip this to draft while the separate unofficial builds is resolved. |
|
Created PR on the official-images repo (docker-library/official-images#12581). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
Description
Motivation and Context
Testing Details
Example Output(if appropriate)
Types of changes
Checklist