add alpine variant for node v0.12 #280
Conversation
|
v0.12 will be removed in a month as per #241. It wasn't included originally because of many build issues. |
|
@LaurentGoderre I tested and didn't found any issue 😄 |
|
I'd like to pass on this. v0.12 will be EOL at the end of December and we deliberately did not add an alpine variant because of this reason. |
|
Why not still provide it before the EOL if we didn't provide it originally by build issues? Didn't see an overhead or something bad. |
|
I'm hesitant to encourage the continued use of node v0.12 past its EOL. |
|
Because we want to actively trying and get people to stop using v0.12 and switch to another LTS release like v4 or v6. |
|
If we do so really want to push the new versions and drop the old ones, maybe we should remove all the v0.12 build there, not just prevent providing v0.12 based on Alpine? |
|
@PeterDaveHello yes, they will be removed as soon as v0.12 goes EOL in a month. |
|
There's one more pending update to v0.12 in early December: nodejs/Release#159 |
|
As the other Debian based images still there, the users can still use v0.12 on that, even tons of other images and method to get v0.12, and v0.12 will still have a new release in next week, why not just make v0.12 as other versions have an alpine based build? I don't think this really help pushing v4 or v6, make only make the users one less choice. |
|
Currently, I can only see these patterns actually:
v0.12 mates the same patterns as others. |
|
I am unsure if we have alpine tests for v0.12 builds.
… On 28 Nov 2016, at 20:04, Peter Dave Hello ***@***.***> wrote:
As the other Debian based images still there, the users can still use v0.12 on that, even tons of other images and method to get v0.12, and v0.12 will still have a new release in next week, why not just make v0.12 as other versions have an alpine based build?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
hmmmm ... isn't the test script scales to the versions automatically? |
|
He means as part of the Node.js testing CI setup, not the test script in this repo Yeah, I think v4 might be the cutoff. |
|
Any possibility to fix that? If no, maybe just close this PR. |
|
At this point, I don't think so. It's too close to the EOL date for the build group to consider adding v0.12 Alpine Tests. |
|
I thought it's tested here? |
|
No, I mean the Node.js ci infrastructure: https://ci.nodejs.org I'm not too familiar with how things are setup there. They have a couple of Alpine nodes for testing, but I don't know the full details of what test are being run. I'm pretty sure, based on past conversations in some other GitHub issues that they were starting with v4 and up. |
|
hmmm ... if the test here is not enough, okay let's close this. |
|
BTW, thank you all for your time. |
No description provided.