fix npm cache clean

[itajaja]

fixes #419

disclaimer: untested

Actually this should be fixed in the template.

[itajaja]

uh, how? is that file generated?

[Starefossen]

It is locally generated before pushing, the template lives in the root folder: Dockerfile-onbuild.template

[itajaja]

I'd argue tho that this only makes sense for node 8

[pesho]

The same template generates all dockerfiles, so the Node 8 one will be overwritten in future releases unless the template is updated. The --force param is backwards-compatible.

[itajaja]

I'll put it in the template then 👍

[Starefossen]

Could you rebase your branch on master?

git fetch origin/maseter
git rebase --no-ff origin/master

And then you'll need to force push to your forked branch.

[gibfahn]

I'm confused, I can't see a change to the npm cache clean line. Am I am I missing something?

[itajaja]

@gibfahn that links points to master, this pr hasn't been merged yet :)

[itajaja]

@Starefossen rebased 🙌

[pesho]

@itajaja the PR is still broken, closing. I've pushed #426 which is a proper fix.

[itajaja]

sorry, don't know what happened, I just rebased in a rush and I probably messed something