Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade alpine in node>=8 to 3.7 #614

Closed
wants to merge 1 commit into from
Closed

Conversation

michael-k
Copy link

No description provided.

@SimenB
Copy link
Member

SimenB commented Jan 20, 2018

Breaking change, can only be done for new images. See #473 for discussion on alternatives.

@nodejs/docker feel free to reopen if you disagree

@SimenB SimenB closed this Jan 20, 2018
@michael-k michael-k deleted the patch-1 branch January 20, 2018 17:00
@michael-k
Copy link
Author

Yes, it is a breaking change, but on the other hand, staying with an old alpine version is a security risk. Therefore both ways (staying with one version of alpine or bumping it) have their flaw and anybody using node in production have to build their own images.

At least for the generic alpine tag (not 9-alpine), I'd consider it ok to do breaking changes for alpine releases as well. It doesn't even guarantee any non-breaking changes for node.

I love that many images on docker hub addressed this by including alpine's version number in the image tag. The issue you references is half a year old and I found no work being done in this direction. :/ (Yes, I know, that's how it is with OSS and I can always do the work myself, if I care enough.)

@hulkish
Copy link

hulkish commented Feb 16, 2018

+1 Can somebody please explain why it's a breaking change for this to go to 3.7?

@michael-k
Copy link
Author

@hulkish See the discussion in docker-library/golang#131 and the linked issues.

@SimenB
Copy link
Member

SimenB commented Feb 16, 2018

Thanks for the link showing the potential breakage!

We would love to publish different versions though. PR very much welcome for making that happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants