Replace --entry-type with --input-type

[GeoffreyBooth]

Per nodejs/modules#300 (comment), this PR replaces --entry-type with --input-type, a flag just like --entry-type but only for --eval, --print and STDIN.

This way we still provide a way to use ESM in those non-file inputs, but we’re removing the footgun that is --entry-type in its current form. To use ESM in files, the files need to end in .mjs or be in a "type": "module" package scope.

Tests and docs updated.

[devsnek]

at this point can we just pr upstream?

[MylesBorins]

What is the solution for extensionless files?

…

On Mon, Apr 1, 2019, 8:45 PM Gus Caplan ***@***.***> wrote: at this point can we just pr upstream? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#66 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecV9RWpo2tn0c3uAty_Do7eTdH7RlEks5vcqg_gaJpZM4cW4pj> .

[MylesBorins]

Also, I think it is reasonable to work off the fork for changes to the roadmap... So we don't cause upstream noise when we don't have consensus on larger changes...thoughts?

…

On Mon, Apr 1, 2019, 9:03 PM Myles Borins ***@***.***> wrote: What is the solution for extensionless files? On Mon, Apr 1, 2019, 8:45 PM Gus Caplan ***@***.***> wrote: > at this point can we just pr upstream? > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#66 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAecV9RWpo2tn0c3uAty_Do7eTdH7RlEks5vcqg_gaJpZM4cW4pj> > . >

[GeoffreyBooth]

What is the solution for extensionless files?

It’s unchanged. As I wrote in nodejs/modules#300 (comment), I’m assuming most people wouldn’t run their extensionless file via node --entry-type=module; for example, you want to just run npm, not node --entry-type=module npm. It defeats the purpose to have a short extensionless filename if you have to run it via a long node command.

So in order to run just npm and for the code of your npm CLI tool to be ESM, npm needs to be a symlink to an .mjs file or a .js file inside a "type": "module" package scope. This is true both under the current --entry-type and this PR. You shouldn’t be putting --entry-type=module in a shebang line because many platforms don’t support that.

[GeoffreyBooth]

Also, I think it is reasonable to work off the fork for changes to the roadmap… So we don’t cause upstream noise when we don’t have consensus on larger changes…thoughts?

👍 We should probably discuss this in the meeting, if people don’t mind. I’m assuming that if this PR gets consensus from our group, I or Myles can open it as a PR upstream. It can’t hurt to get consensus among us first; I feel like our upstream PRs will get accepted more easily if we resolve all our internal disagreements privately first.

[Fishrock123]

I only hope that no one gets confused thinking that this affects process.stdin somehow...

[GeoffreyBooth]

Approved per consensus in 2019-04-10 meeting.

[GeoffreyBooth]

@MylesBorins should I merge this into modules-lkgr or open this as a PR against upstream?

[MylesBorins]

Just open a pr upstream

…

On Apr 10, 2019, at 9:58 PM, Geoffrey Booth ***@***.***> wrote: @MylesBorins <https://github.com/MylesBorins> should I merge this into modules-lkgr or open this as a PR against upstream? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#66 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecVzMy_da86f6jUiBdMuOS95Zoem92ks5vfkKCgaJpZM4cW4pj>.

[GeoffreyBooth]

Opened as nodejs/node#27184.

[GeoffreyBooth]

nodejs/node#27184 was merged.