Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-Install Failure on node 12.16.2 #46

Closed
Snugug opened this issue Apr 8, 2020 · 14 comments
Closed

Post-Install Failure on node 12.16.2 #46

Snugug opened this issue Apr 8, 2020 · 14 comments
Assignees
Labels

Comments

@Snugug
Copy link

Snugug commented Apr 8, 2020

On Node 12.16.2/npm 6.14.4, when installing this module, the following error is thrown during post-install. I believe it's because the module is trying to find icu4c-data@651 but the module ships with icu4c-data@641. I'm unsure why this patch Node bump/minor NPM bump causes this breakage, but installation does not fail on 12.16.1/6.13.4.

Error: /opt/hostedtoolcache/node/12.16.2/x64/bin/node /opt/hostedtoolcache/node/12.16.2/x64/lib/node_modules/npm/bin/npm-cli.js install icu4c-data@65l --> status 1
    at npmInstallNpm (/home/runner/work/project/project/node_modules/full-icu/install-spawn.js:62:9)
    at Object.<anonymous> (/home/runner/work/project/project/node_modules/full-icu/postinstall.js:72:2)
    at Module._compile (internal/modules/cjs/loader.js:1156:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:74:12)
    at internal/main/run_main_module.js:18:47
npm ERR! code ELIFECYCLE
@A
Copy link

A commented Apr 9, 2020

Also fixed this issue by temporary downgrade node version to 12.16.1

@zackerydev
Copy link

We also hit this issue almost instantly after 12.16.2 was released in our CI that was running against Node 12.x and Docker builds using node12-slim.

Had to downgrade to 12.16.1 to fix our builds and get everything going again

@jacekk
Copy link

jacekk commented Apr 10, 2020

Quite a change in Node --> nodejs/node#30232 . Anyone knows Captain America to save us? ;)

@srl295
Copy link
Member

srl295 commented Apr 10, 2020

ok, I see.

@srl295
Copy link
Member

srl295 commented Apr 10, 2020

Now uploading 65...

@srl295 srl295 self-assigned this Apr 10, 2020
@srl295 srl295 added the task label Apr 10, 2020
@srl295
Copy link
Member

srl295 commented Apr 10, 2020

I'm unsure why this patch Node bump/minor NPM bump causes this breakage, but installation does not fail on 12.16.1/6.13.4.

because i didn't upload the 65 binaries yet

@srl295
Copy link
Member

srl295 commented Apr 10, 2020

people, NPM is timing out trying to do the upload.

@srl295
Copy link
Member

srl295 commented Apr 10, 2020

65l uploaded. Uploading 65b now.

$ docker run --rm -it node:12-slim npm i full-icu

> full-icu@1.3.1 postinstall /node_modules/full-icu
> node postinstall.js

npm install icu4c-data@65l (Node 12.16.2 and small-icu 65.1) -> icudt65l.dat
full-icu$ /usr/local/bin/node /usr/local/lib/node_modules/npm/bin/npm-cli.js install icu4c-data@65l
npm notice created a lockfile as package-lock.json. You should commit this file.
+ icu4c-data@0.65.2
added 1 package from 1 contributor and audited 1 package in 6.931s
found 0 vulnerabilities

 √ icudt65l.dat (link)

@srl295 srl295 closed this as completed Apr 10, 2020
@srl295
Copy link
Member

srl295 commented Apr 10, 2020

65b also uploaded

@srl295
Copy link
Member

srl295 commented Apr 10, 2020

66b uplaoded, hopefully 66l soon

@zackerydev
Copy link

@srl295 Thanks for the fix! Can confirm this resolved our issue 🎉

@jacekk
Copy link

jacekk commented Apr 10, 2020

@srl295 Same here. Thx

@MylesBorins
Copy link

Hey All, from node team here. Sorry about not updating sooner. Will give y'all a heads up here next time

@srl295
Copy link
Member

srl295 commented Apr 10, 2020

Hey All, from node team here. Sorry about not updating sooner. Will give y'all a heads up here next time

Good incentive to get #36 done… makes this issue go away!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants