tools: Update icu to 65.1 #30232

albertyw · 2019-11-03T01:47:52Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
~~tests and/or benchmarks are included~~
~~documentation is changed or added~~
commit message follows commit guidelines

albertyw · 2019-11-03T01:50:02Z

I followed the upgrade instructions in https://github.com/nodejs/node/blob/master/tools/icu/README.md. I'm having trouble getting tests to run correctly locally. I'm hoping that CI will validate the correctness of this PR.

hiagodotme · 2019-11-03T18:35:18Z

@albertyw I'm having production issues because of this. How did you solve this problem?

targos · 2019-11-03T18:42:00Z

@nodejs/intl

nodejs-github-bot · 2019-11-04T07:05:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26307/

nodejs-github-bot · 2019-11-05T08:15:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26342/

GitArika · 2019-11-07T18:16:15Z

When this update arrives, will nodejs LTS v8 and v10 also change?

APIs on AWS are being affected by this issue.

richardlau · 2019-11-07T18:43:13Z

When this update arrives, will nodejs LTS v8 and v10 also change?

APIs on AWS are being affected by this issue.

Node.js 8 is unlikely as it will be EOL at the end of the year and we really want to avoid having to do a release there. As for 10 we have updated ICU in an LTS release in the past but we've been asked to not do so in the future specifically not to break AWS deployments: nodejs/Release#483

cc @nodejs/lts @nodejs/intl

ex1st · 2019-11-07T18:53:50Z

Node.js 8 is unlikely as it will be EOL at the end of the year and we really want to avoid having to do a release there. As for 10 we have updated ICU in an LTS release in the past but we've been asked to not do so in the future specifically not to break AWS deployments: nodejs/Release#483

Hello @richardlau and @srl295.
Will be updated npm module full-icu to 65.1 (for v12 at least)? Thank you.

mhdawson

Rubber stamp LGTM since @srl295 believes it looks good.

nodejs-github-bot · 2019-11-10T16:38:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26498/

mhdawson · 2019-11-10T16:39:10Z

Rebuild due to failures in original CI run: https://ci.nodejs.org/job/node-test-pull-request/26498/

srl295 · 2019-11-12T22:33:26Z

Travis says:

The job exceeded the maximum time limit for jobs, and has been terminated.

Jenkins says memory exhausted on debian9-docker-armv7

@nodejs/build what's happening here?

richardlau · 2019-11-12T22:48:22Z

Travis says:

The job exceeded the maximum time limit for jobs, and has been terminated.

There was a V8 update that landed on master between this PR being opened and the most recent (force) push. The Node.js build takes too long on Travis (which imposes a 50 min time limit on jobs) so we rely on ccache for the builds to complete in time. In this case the cache was stored for the previous version of V8 (at the time the PR was opened) which meant that large numbers of V8 files needed to be recompiled.

I've wiped the cache in Travis for this PR and restarted the build. Without a PR cache Travis defaults to the cache for the target branch (master).

richardlau · 2019-11-12T23:38:07Z

Travis says:

The job exceeded the maximum time limit for jobs, and has been terminated.

There was a V8 update that landed on master between this PR being opened and the most recent (force) push. The Node.js build takes too long on Travis (which imposes a 50 min time limit on jobs) so we rely on ccache for the builds to complete in time. In this case the cache was stored for the previous version of V8 (at the time the PR was opened) which meant that large numbers of V8 files needed to be recompiled.

I've wiped the cache in Travis for this PR and restarted the build. Without a PR cache Travis defaults to the cache for the target branch (master).

hmm that didn't work 😞 -- I guess V8 depends on ICU so the ICU update means V8 also needs to be recompiled. I'm not sure what we can do here (AFAICT there's no way to increase Travis' job time limit).

albertyw · 2019-11-13T00:52:50Z

let me rebase to get the most recent node master and see if that fixes things.

pamydev · 2019-11-13T15:59:56Z

any solution guys?

srl295 · 2019-11-13T16:10:50Z

When this update arrives, will nodejs LTS v8 and v10 also change?

APIs on AWS are being affected by this issue.

which issue? the time zone? you can always build another node with a different ICU, or an updated time zone.

nodejs-github-bot · 2019-12-05T10:00:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27349/

nodejs-github-bot · 2019-12-05T16:25:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27356/

Update the version of the bundled ICU (deps/icu-small) to ICU version 65.2. Fixes: #30211 Fixes: #29540 PR-URL: #30232 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

richardlau · 2019-12-06T01:41:06Z

Landed in 418dd68.

srl295 · 2019-12-06T01:49:32Z

ICU 66preview announced today - http://site.icu-project.org/download/66 ( it won't ship until March 2020). so, better late than never!

paulodiovani · 2019-12-06T14:48:16Z

Landed in 418dd68.

But not in v13.3.0,
any idea in which version it ships?

srl295 · 2019-12-06T16:36:21Z

13.3.0 shipped 3 days ago. This change landed less than one day ago. It will be a later release Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Paulo Diovani Gonçalves <notifications@github.com> Sent: Friday, December 6, 2019 6:48:20 AM To: nodejs/node <node@noreply.github.com> Cc: Steven R. Loomis <srl295@gmail.com>; Mention <mention@noreply.github.com> Subject: Re: [nodejs/node] tools: Update icu to 65.1 (#30232) Landed in 418dd68<418dd68>. But not in v13.3.0<https://github.com/nodejs/node/releases/tag/v13.3.0>, any idea in which version it ships? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#30232?email_source=notifications&email_token=AAGQZM5K3S4I6WDEBNPBLQTQXJQ3JA5CNFSM4JIJJ6QKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGEJNWI#issuecomment-562599641>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAGQZM4O6OJVJPT3TK442RDQXJQ3JANCNFSM4JIJJ6QA>.

Update the version of the bundled ICU (deps/icu-small) to ICU version 65.2. Fixes: #30211 Fixes: #29540 PR-URL: #30232 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

targos · 2020-01-13T15:23:48Z

Should this be backported to v12.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

Update the version of the bundled ICU (deps/icu-small) to ICU version 65.2. Fixes: nodejs#30211 Fixes: nodejs#29540 Backport-PR-URL: nodejs#31434 PR-URL: nodejs#30356 PR-URL: nodejs#30232

richardlau · 2020-01-21T04:16:03Z

Should this be backported to v12.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

A backport PR has been raised (#31433) but given that 13.x/master use full-icu and 12.x small-icu it may be easier to update ICU on 12.x directly following the instructions in https://github.com/nodejs/node/blob/v12.x/tools/icu/README.md rather than attempting to backport this PR.

Update the version of the bundled ICU (deps/icu-small) to ICU version 65.2. Fixes: nodejs#30211 Fixes: nodejs#29540 PR-URL: nodejs#30232 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

Update the version of the bundled ICU (deps/icu-small) to ICU version 65.2. Fixes: #30211 Fixes: #29540 Backport-PR-URL: #31433 PR-URL: #30232 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

albertyw force-pushed the update-icu branch from dd80923 to 37e1126 Compare November 3, 2019 05:47

richardlau mentioned this pull request Nov 3, 2019

The date offset in Brazil (America/Sao_Paulo) is incorrect nodejs/help#2269

Closed

albertyw force-pushed the update-icu branch from 37e1126 to 80d70c1 Compare November 3, 2019 21:07

gengjiawen requested a review from ryzokuken November 5, 2019 01:29

gengjiawen assigned srl295 and unassigned srl295 Nov 5, 2019

gengjiawen requested a review from srl295 November 5, 2019 01:29

srl295 approved these changes Nov 5, 2019

View reviewed changes

codebytere mentioned this pull request Nov 7, 2019

Brasilia summer time saving electron/electron#20998

Closed

3 tasks

richardlau mentioned this pull request Nov 8, 2019

Node assuming Summer Time that no longer exists (Brasilia) #30332

Closed

mhdawson approved these changes Nov 10, 2019

View reviewed changes

albertyw mentioned this pull request Nov 10, 2019

tools: update tzdata to 2019c #30356

Closed

4 tasks

albertyw force-pushed the update-icu branch from 80d70c1 to b83c25f Compare November 11, 2019 01:02

albertyw force-pushed the update-icu branch from b83c25f to 0347651 Compare November 13, 2019 00:56

richardlau closed this Dec 6, 2019

MylesBorins mentioned this pull request Dec 13, 2019

v13.4.0 proposal #30937

Merged

targos added the backport-requested-v12.x label Jan 13, 2020

jameshilliard mentioned this pull request Jan 21, 2020

[v12.x backport] tools: update icu to 65.1 #31433

Closed

albertyw mentioned this pull request Jan 21, 2020

[v12.x backport] Update tzdata icu #31434

Closed

3 tasks

srl295 mentioned this pull request Mar 18, 2020

deps: ICU 66.1 #32348

Closed

MylesBorins added backported-to-v12.x and removed backport-requested-v12.x labels Apr 3, 2020

codebytere mentioned this pull request Apr 3, 2020

v12.16.2 proposal #32313

Merged

jacekk mentioned this pull request Apr 10, 2020

Post-Install Failure on node 12.16.2 nodejs/full-icu-npm#46

Closed

albertyw deleted the update-icu branch January 8, 2022 05:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: Update icu to 65.1 #30232

tools: Update icu to 65.1 #30232

albertyw commented Nov 3, 2019

albertyw commented Nov 3, 2019

hiagodotme commented Nov 3, 2019 •

edited

Loading

targos commented Nov 3, 2019

nodejs-github-bot commented Nov 4, 2019

nodejs-github-bot commented Nov 5, 2019

GitArika commented Nov 7, 2019

richardlau commented Nov 7, 2019

ex1st commented Nov 7, 2019 •

edited

Loading

mhdawson left a comment

nodejs-github-bot commented Nov 10, 2019

mhdawson commented Nov 10, 2019

srl295 commented Nov 12, 2019 •

edited

Loading

richardlau commented Nov 12, 2019

richardlau commented Nov 12, 2019

albertyw commented Nov 13, 2019

pamydev commented Nov 13, 2019

srl295 commented Nov 13, 2019

nodejs-github-bot commented Dec 5, 2019

nodejs-github-bot commented Dec 5, 2019

richardlau commented Dec 6, 2019

srl295 commented Dec 6, 2019

paulodiovani commented Dec 6, 2019

srl295 commented Dec 6, 2019 via email

targos commented Jan 13, 2020

richardlau commented Jan 21, 2020

tools: Update icu to 65.1 #30232

tools: Update icu to 65.1 #30232

Conversation

albertyw commented Nov 3, 2019

Checklist

albertyw commented Nov 3, 2019

hiagodotme commented Nov 3, 2019 • edited Loading

targos commented Nov 3, 2019

nodejs-github-bot commented Nov 4, 2019

nodejs-github-bot commented Nov 5, 2019

GitArika commented Nov 7, 2019

richardlau commented Nov 7, 2019

ex1st commented Nov 7, 2019 • edited Loading

mhdawson left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 10, 2019

mhdawson commented Nov 10, 2019

srl295 commented Nov 12, 2019 • edited Loading

richardlau commented Nov 12, 2019

richardlau commented Nov 12, 2019

albertyw commented Nov 13, 2019

pamydev commented Nov 13, 2019

srl295 commented Nov 13, 2019

nodejs-github-bot commented Dec 5, 2019

nodejs-github-bot commented Dec 5, 2019

richardlau commented Dec 6, 2019

srl295 commented Dec 6, 2019

paulodiovani commented Dec 6, 2019

srl295 commented Dec 6, 2019 via email

targos commented Jan 13, 2020

richardlau commented Jan 21, 2020

hiagodotme commented Nov 3, 2019 •

edited

Loading

ex1st commented Nov 7, 2019 •

edited

Loading

srl295 commented Nov 12, 2019 •

edited

Loading