Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12.x backport] Update tzdata icu #31434

Closed
wants to merge 1 commit into from

Conversation

albertyw
Copy link
Contributor

@albertyw albertyw commented Jan 21, 2020

Backport of #30211 and #30232 (combined)

Includes these two commits on the master branch:

commit 418dd68
Author: Albert Wang git@albertyw.com
Date: Sat Nov 2 18:08:46 2019

tools: update icu to 65.1

Update the version of the bundled ICU (deps/icu-small) to ICU version
65.2.

Fixes: https://github.com/nodejs/node/issues/30211
Fixes: https://github.com/nodejs/node/issues/29540

PR-URL: https://github.com/nodejs/node/pull/30232
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

commit 31ea341
Author: Albert Wang git@albertyw.com
Date: Sun Nov 10 14:28:15 2019

tools: update tzdata to 2019c

Fixes: https://github.com/nodejs/node/issues/30211
PR-URL: https://github.com/nodejs/node/pull/30356
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Update the version of the bundled ICU (deps/icu-small) to ICU version
65.2.

Fixes: nodejs#30211
Fixes: nodejs#29540
Backport-PR-URL: nodejs#31434
PR-URL: nodejs#30356
PR-URL: nodejs#30232
@jameshilliard
Copy link

I included the tzdata update in #31433.

@albertyw
Copy link
Contributor Author

albertyw commented Jan 21, 2020

Just realized that @jameshilliard made this same PR in #31433.

@albertyw albertyw closed this Jan 21, 2020
@albertyw albertyw deleted the update-tzdata-icu branch January 8, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants