Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: ICU 66.1 #32348

Closed
wants to merge 0 commits into from
Closed

deps: ICU 66.1 #32348

wants to merge 0 commits into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Mar 18, 2020 •
edited
Loading

It's that time again…  Prior PR: #30232 for 65.2

By the way, this is a very small focussed release of ICU—just Unicode 13 and selected patches.

@srl295 srl295 added i18n-api Issues and PRs related to the i18n implementation. dependencies Pull requests that update a dependency file. labels Mar 18, 2020
@srl295 srl295 requested review from richardlau and ryzokuken March 18, 2020 19:50
@srl295 srl295 self-assigned this Mar 18, 2020
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 18, 2020
@srl295 srl295 marked this pull request as ready for review March 18, 2020 19:52
@srl295
Copy link
Member Author

srl295 commented Mar 18, 2020

See also #32347 (not required to land this)

@srl295 srl295 requested a review from devsnek March 18, 2020 20:21
ryzokuken
ryzokuken approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@richardlau richardlau added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 18, 2020
jasnell
jasnell approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

mhdawson
mhdawson approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29935/

srl295 added a commit that referenced this pull request Mar 21, 2020
@srl295
deps: update to ICU 66.1
74e7e72 
- ICU 66.1 http://site.icu-project.org/download/66
- Unicode 13
- CLDR 36.1
- Updated ./LICENSE

PR-URL: #32348
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@srl295 srl295 closed this Mar 21, 2020
@srl295
Copy link
Member Author

srl295 commented Mar 21, 2020

Landed in 74e7e72

@srl295 srl295 deleted the icu-66.1 branch March 21, 2020 00:30
@srl295
Copy link
Member Author

srl295 commented Mar 21, 2020

fyi @nodejs/i18n @nodejs/i18n-api

MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@srl295 @MylesBorins
deps: update to ICU 66.1
2cb9f7a 
- ICU 66.1 http://site.icu-project.org/download/66
- Unicode 13
- CLDR 36.1
- Updated ./LICENSE

PR-URL: #32348
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 24, 2020
Merged
@targos
Copy link
Member

targos commented Apr 22, 2020

Please open a backport PR for v12.x-staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@jasnell jasnell jasnell approved these changes

@devsnek devsnek Awaiting requested review from devsnek

Assignees

@srl295 srl295

Labels
dependencies Pull requests that update a dependency file. i18n-api Issues and PRs related to the i18n implementation. meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@srl295 @nodejs-github-bot @targos @jasnell @richardlau @mhdawson @ryzokuken