Created smoketest verifying the bot starts (#38)

.travis.yml

@@ -3,3 +3,4 @@ language: node_js
 node_js:
   - 4
   - 5
+  - 6

app.js

@@ -0,0 +1,21 @@
+'use strict'
+
+require('dotenv').load({ silent: true })
+
+const glob = require('glob')
+const express = require('express')
+const bodyParser = require('body-parser')
+
+const captureRaw = (req, res, buffer) => { req.raw = buffer }
+
+const app = express()
+app.use(bodyParser.json({ verify: captureRaw }))
+require('./lib/github-events')(app)
+
+// load all the files in the scripts folder
+glob.sync(process.argv[2] || './scripts/**/*.js').forEach((file) => {
+  console.log('loading:', file)
+  require(file)(app)
+})
+
+module.exports = app

lib/github-client.js

@@ -14,7 +14,7 @@ const githubClient = new GitHub({
 
 githubClient.authenticate({
   type: 'oauth',
-  token: process.env.GITHUB_TOKEN
+  token: process.env.GITHUB_TOKEN || 'invalid-placeholder-token'
 })
 
 module.exports = githubClient

lib/github-events.js

@@ -28,25 +28,10 @@ module.exports = (app) => {
 
     res.end()
 
-    emit(data)
+    app.emitGhEvent(data)
   })
 
-  if (process.env.SSE_RELAY) {
-    const EventSource = require('eventsource')
-    var es = new EventSource(process.env.SSE_RELAY)
-    es.onmessage = (e) => {
-      try {
-        const data = JSON.parse(e.data)
-        if (!data.action) return
-
-        emit(data)
-      } catch (e) {
-        console.error(e)
-      }
-    }
-  }
-
-  function emit (data) {
+  app.emitGhEvent = function emitGhEvent (data) {
     const repo = data.repository
     const org = repo.owner.login || data.organization.login
 

package.json

@@ -24,6 +24,7 @@
   "devDependencies": {
     "eventsource": "^0.2.1",
     "nodemon": "^1.9.1",
+    "request": "^2.72.0",
     "standard": "^6.0.7",
     "tap": "^5.7.1"
   }

scripts/ping.js

@@ -0,0 +1,7 @@
+'use strict'
+
+module.exports = function (app) {
+  app.get('/ping', (req, res) => {
+    res.end('pong')
+  })
+}

server.js

@@ -1,24 +1,25 @@
 'use strict'
 
-require('dotenv').load({ silent: true })
-
-const glob = require('glob')
-const express = require('express')
-const bodyParser = require('body-parser')
-
-const captureRaw = (req, res, buffer) => { req.raw = buffer }
-
-const app = express()
-app.use(bodyParser.json({ verify: captureRaw }))
-require('./lib/github-events.js')(app)
-
-// load all the files in the scripts folder
-glob.sync(process.argv[2] || './scripts/**/*.js').forEach((file) => {
-  console.log('loading:', file)
-  require(file)(app)
-})
+const app = require('./app')
 
 const port = process.env.PORT || 3000
 app.listen(port, () => {
-  console.log('Example app listening on port', port)
+  console.log('Bot listening on port', port)
 })
+
+// may open up an SSE relay channel helpful for local debugging
+// of github repository events, wo/having to deploy changes
+if (process.env.SSE_RELAY) {
+  const EventSource = require('eventsource')
+  const es = new EventSource(process.env.SSE_RELAY)
+  es.onmessage = (e) => {
+    try {
+      const data = JSON.parse(e.data)
+      if (!data.action) return
+
+      app.emitGhEvent(data)
+    } catch (e) {
+      console.error('Error while receiving SSE relay message', e)
+    }
+  }
+}

test/ping.test.js

@@ -0,0 +1,21 @@
+'use strict'
+
+const tap = require('tap')
+const request = require('request')
+
+const app = require('../app')
+
+tap.test('GET /ping responds with status 200 / "pong"', (t) => {
+  const server = app.listen()
+  const port = server.address().port
+  const url = `http://localhost:${port}/ping`
+
+  t.plan(3)
+  t.tearDown(() => server.close())
+
+  request(url, (err, res, body) => {
+    t.equal(err, null)
+    t.equal(res.statusCode, 200)
+    t.equal(res.body, 'pong')
+  })
+})