Skip to content

Commit

Permalink
jenkins: check successful response before reading (#247)
Browse files Browse the repository at this point in the history
While having a look at recent error logs, this fatal log stood out:

```
02:48:11.721 FATAL bot: Unchaught exception, terminating bot process immediately
    TypeError: Cannot read property 'data' of undefined
        at githubClient.pullRequests.getCommits (/.../github-bot/lib/push-jenkins-update.js:92:29)
        at module.exports.sendError (/.../github-bot/node_modules/github/lib/index.js:874:7)
        at /.../github-bot/node_modules/github/lib/index.js:882:21
        at callCallback (/.../github-bot/node_modules/github/lib/index.js:738:9)
        at IncomingMessage.<anonymous> (/.../github-bot/node_modules/github/lib/index.js:807:13)
        at IncomingMessage.emit (events.js:194:15)
        at endReadableNT (_stream_readable.js:1125:12)
        at process._tickCallback (internal/process/next_tick.js:63:19)
```

Since we never want these kinds of errors to happen since they
end up killing the bot process, this fix is pushed to ensure we
don't naively read the response from github.com until we know the
request didn't fail for some reason.

Refs #246
  • Loading branch information
phillipj authored Oct 17, 2019
1 parent 4cce2b9 commit ab459fd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/push-jenkins-update.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,11 @@ function findLatestCommitInPr (options, cb, pageNumber = 1) {
page: pageNumber,
per_page: 100
}, (err, res) => {
const commitMetas = res.data || []
if (err) {
return cb(err)
}

const commitMetas = res.data || []
const lastPageURL = githubClient.hasLastPage(res)
if (lastPageURL) {
return findLatestCommitInPr(options, cb, pageNumberFromURL(lastPageURL))
Expand Down

0 comments on commit ab459fd

Please sign in to comment.