Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dont-land-on-v6.x and v8.x labels for ES Modules PRs #164

Closed
gibfahn opened this issue Jan 24, 2018 · 4 comments
Closed

Add dont-land-on-v6.x and v8.x labels for ES Modules PRs #164

gibfahn opened this issue Jan 24, 2018 · 4 comments

Comments

@gibfahn
Copy link
Member

gibfahn commented Jan 24, 2018

I'm not sure if this is possible, but if someone adds the ES Modules label, the bot should add the dont-land-on labels.

e.g. nodejs/node#17786

cc/ @MylesBorins
@gibfahn gibfahn mentioned this issue Jan 24, 2018
Closed
@MylesBorins
Copy link
Contributor

should they be don't land for 8.x?

@gibfahn
Copy link
Member Author

gibfahn commented Jan 26, 2018

Sorry, bad grammar, I meant dont-land-on for v6.x and v8.x

i.e. dont-land-on-v{6,8}.x

@joyeecheung
Copy link
Member

The bot should be able to add the ES Modules label by itself anyway.

@richardlau
Copy link
Member

This can be closed as Node.js 6 and 8 are End-of-Life.

@targos targos closed this as completed Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@MylesBorins @targos @joyeecheung @richardlau @gibfahn