-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt-backport: unlabel and clean labeling #104
attempt-backport: unlabel and clean labeling #104
Conversation
e25c998
to
9acb63e
Compare
Other than my recent negate comments, this LGTM |
@phillipj On second look I think my previous checks were wrong. We only want to remove it if we added it. |
@Fishrock123 not sure I follow you.. If we only want the bot to remove labels it added itself previously, that still means my If I understand the current code correctly, labels added by the bot will not be removed since it will prevent |
9acb63e
to
a13ed9a
Compare
@phillipj You're right. I read it wrong. Updated. |
Should fix #100 (comment) while also giving a way to see when a PR update has changed the backportability.
This was always on the plans, I just hadn't gotten to it before.
cc @phillipj and maybe also @thealphanerd
I don't really trust myself that it'l work without testing though, but I have a plan on how to test the script, so I'm going to do that next and then rebase this ontop.