Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update Ruff to 0.3.1 #226

Merged
merged 1 commit into from
Mar 8, 2024
Merged

chore: update Ruff to 0.3.1 #226

merged 1 commit into from
Mar 8, 2024

Conversation

targos
Copy link
Member

@targos targos commented Mar 7, 2024 •
edited
Loading 

- Fix new UP032 errors
- Fix deprecated Ruff config structure

BEGIN_COMMIT_OVERRIDE
fix: update Ruff to 0.3.1
END_COMMIT_OVERRIDE

@targos targos requested a review from cclauss March 7, 2024 09:04
legendecas
legendecas reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pin ruff version as well?

@legendecas
Copy link
Member

FWIW, I pinned ruff to v0.3.0 in #223

@targos
chore: update Ruff to 0.3.1
4eddbb3 
- Fix new UP032 errors
- Fix deprecated Ruff config structure
@targos targos changed the title chore: fix new UP032 Ruff error and Ruff config chore: update Ruff to 0.3.1 Mar 7, 2024
@targos
Copy link
Member Author

targos commented Mar 7, 2024

Ok, I changed this to a Ruff update.

@lukekarrys lukekarrys mentioned this pull request Mar 7, 2024
Closed
@cclauss cclauss mentioned this pull request Mar 8, 2024
Closed
2 tasks
@cclauss cclauss merged commit 876ccaf into main Mar 8, 2024
20 checks passed
@cclauss cclauss deleted the fix-ruff branch March 8, 2024 04:00
@cclauss
Copy link
Contributor

cclauss commented Mar 8, 2024

My preference is that we do not pin ruff because it is still in a state of flux and fixing Python code incrementally in a JavaScript codebase ensures that the squeaky wheel gets the grease. If we silence ruff then we will build a backlog of diverse changes that will be difficult to implement and get reviewed.

@cclauss cclauss mentioned this pull request Mar 8, 2024
Merged
2 tasks
@legendecas legendecas mentioned this pull request Mar 11, 2024
Merged
@lukekarrys lukekarrys mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@targos @legendecas @cclauss