-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs clarification #1080
Comments
I am not sure how exactly the windows (external) behavior is different from UNIX, |
@boneskull - a PR in progress to address your concerns.
I did the below check and determined that the var net = require('net')
const p= '\\\\.\\pipe\\test.sock'
console.log(p)
var k = net.createServer((s) => {
s.end('hello!')
}).listen(p, () => {
var socket = net.connect(p)
socket.on('data', (d) => {
// k.close()
})
})
from the powershell:
Hoep this helps! |
In UNIX, the domain sockets once created persists until unlinked. Clarify which ones are persisted and which ones are cleared manually. In Windows, named pipes are cleared based on reference count, implemented by the underlying system. Disambiguate this from Garbage collection of the Node.js runtime. Refs: nodejs/help#1080
@boneskull - have a look at the PR and see if you believe the changes meets your expected clarity and coverage. |
In UNIX, the domain sockets once created persists until unlinked. Clarify which ones are persisted and which ones are cleared manually. In Windows, named pipes are cleared based on reference count, implemented by the underlying system. Disambiguate this from Garbage collection of the Node.js runtime. Refs: nodejs/help#1080 PR-URL: #19471 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
closing as addressed. |
In UNIX, the domain sockets once created persists until unlinked. Clarify which ones are persisted and which ones are cleared manually. In Windows, named pipes are cleared based on reference count, implemented by the underlying system. Disambiguate this from Garbage collection of the Node.js runtime. Refs: nodejs/help#1080 PR-URL: nodejs#19471 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
In UNIX, the domain sockets once created persists until unlinked. Clarify which ones are persisted and which ones are cleared manually. In Windows, named pipes are cleared based on reference count, implemented by the underlying system. Disambiguate this from Garbage collection of the Node.js runtime. Refs: nodejs/help#1080 PR-URL: #19471 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
I'm checking out the documentation on IPC connections, but the wording is unclear to me.
It says (basically) that a named pipe in UNIX "persist until unlinked". This seems to imply that one must manually unlink when finished using it. This is untrue, because calling
close()
on theServer
object will apparently do so for you (?).In Windows, it claims pipes will "not persist", and are removed "when the last reference to them is closed". How exactly does this differ from the UNIX behavior? Does it have something to do with garbage collection, or the socket object falling out of scope...?
Thanks!
The text was updated successfully, but these errors were encountered: