How may I help?

[ryzokuken]

Hey everyone!
I am a junior developer and wanted to get involved and contribute. That said, I'd definitely need some assistance finding my way for the first few days. If you're working on the project and could use some help, please let me know how I may join in.

[gireeshpunathil]

@ryzokuken - wish you a great experience with node.js.

You can start by looking through good-first-issues and mentor-available.

and pick choose one or two of your choice, and start hacking. Let others know you are working on it.

A low hanging PR for you for a starter: fix the typo in this line

[ryzokuken]

Thanks, @gireeshpunathil! I'll jump in right away.

I see the line says:

// - encoding - an optional encoding, relevant is val is a string

I had been wondering what the appropriate sentence would be. I know that encoding is an "optional encoding value which expects type String". It should probably default to UTF-8. What exactly should I mention, though?

[gireeshpunathil]

relevant is val is a string
relevant if val is a string
:)

[ryzokuken]

Great! I'll make that change and submit a PR.

[ryzokuken]

@gireeshpunathil I should make the change against the 10.0.0-proposal branch, right?

[devsnek]

@ryzokuken target the master branch. when we're creating releases backports will target versioned branches, but thats about the only reason

[ryzokuken]

@devsnek so for the record, I make a branch off the 10.0.0-proposal branch, make my changes and make the PR against not the 10.0.0-proposal branch, but the master branch instead?

[gireeshpunathil]

please follow the Pull Requests section in contributor's guide - that is comprehensive.

[ryzokuken]

@gireeshpunathil that's what I had been looking into, and got confused.

The guide says: As a best practice to keep your development environment as organized as possible, create local branches to work within. These should also be created directly off of the master branch.

However, I don't think the commit has landed in master yet.

[ryzokuken]

Wait, it has. That helps.

[ryzokuken]

@gireeshpunathil @devsnek I submitted the PR! Here it is: nodejs/node#19126

[gireeshpunathil]

The purpose is met, closing.