This repository has been archived by the owner on Nov 6, 2022. It is now read-only.
Support ICE/1.x for SOURCE requests. #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@indutny Can I get a LGTM? Congrats on the 5-0, by the way! #футбола |
indutny
approved these changes
Oct 29, 2018
ploxiln
reviewed
Oct 29, 2018
| UPDATE_STATE(s_req_http_I); | ||
| break; | ||
| } | ||
| /* fall through */ |
There was a problem hiding this comment.
this falls-through to break; but looks like maybe it was intended to fall-through to SET_ERRNO(HPE_INVALID_CONSTANT)
There was a problem hiding this comment.
Huh, you're right. Maybe I botched a rebase because I don't recall writing it like that. I'll fix it up before landing, thanks for pointing it out.
Normal clients sends "GET / HTTP/1.0" but Shoutcast clients send "SOURCE / ICE/1.0". Accept that as an alternative but only for SOURCE requests. Fixes: nodejs#410 PR-URL: nodejs#431 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Pierce Lopez <pierce.lopez@gmail.com>
|
Landed with an extra test in 4dae120. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normal clients sends "GET / HTTP/1.0" but Shoutcast clients send
"SOURCE / ICE/1.0". Accept that as an alternative but only for
SOURCE requests.
Fixes: #410