This repository has been archived by the owner on Jul 6, 2018. It is now read-only.
http2: another round of updates #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
* Follow the model of the existing http code and pass the headers in to js as an array. Building the array on the native side then converting it to an object on the js side is generally faster than building the object on the native side. This also allows us to eliminate some duplicated checks. * Fill in additional doc details * Work on timeouts
jasnell
added a commit
that referenced
this pull request
Jun 6, 2017
* Follow the model of the existing http code and pass the headers in to js as an array. Building the array on the native side then converting it to an object on the js side is generally faster than building the object on the native side. This also allows us to eliminate some duplicated checks. * Fill in additional doc details * Work on timeouts PR-URL: #148 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
Landed! |
jasnell
added a commit
to jasnell/http2-1
that referenced
this pull request
Jun 22, 2017
* Follow the model of the existing http code and pass the headers in to js as an array. Building the array on the native side then converting it to an object on the js side is generally faster than building the object on the native side. This also allows us to eliminate some duplicated checks. * Fill in additional doc details * Work on timeouts PR-URL: nodejs#148 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
added a commit
to jasnell/http2-1
that referenced
this pull request
Jul 10, 2017
* Follow the model of the existing http code and pass the headers in to js as an array. Building the array on the native side then converting it to an object on the js side is generally faster than building the object on the native side. This also allows us to eliminate some duplicated checks. * Fill in additional doc details * Work on timeouts PR-URL: nodejs#148 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
added a commit
to jasnell/http2-1
that referenced
this pull request
Jul 14, 2017
* Follow the model of the existing http code and pass the headers in to js as an array. Building the array on the native side then converting it to an object on the js side is generally faster than building the object on the native side. This also allows us to eliminate some duplicated checks. * Fill in additional doc details * Work on timeouts PR-URL: nodejs#148 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting another round of updates...
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)