Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

automatic approve and merge translation PRs #161

Closed
maddhruv opened this issue Sep 21, 2018 · 7 comments
Closed

automatic approve and merge translation PRs #161

maddhruv opened this issue Sep 21, 2018 · 7 comments
Assignees

Comments

@maddhruv
Copy link
Contributor

There's no code in the PRs to be reviewed and merged manually everytime
can we do something to timely accept and merge the PRs

@zeke
Copy link
Contributor

zeke commented Sep 21, 2018

@dependabot might be good for this.

https://twitter.com/zeke/status/1043219917913219072

@maddhruv
Copy link
Contributor Author

so https://probot.github.io/ is something that might help us go ahead

@zeke
Copy link
Contributor

zeke commented Sep 22, 2018

Probot is a framework for building bots. We could build a custom bot to merge Crowdin PRs, but I think if there's something that already exists to solve this problem, we should consider using it.

@maddhruv
Copy link
Contributor Author

Yeah indeed!
But would the 2 approvals merge block setting hurdle the bot?

@zeke
Copy link
Contributor

zeke commented Sep 23, 2018

We can change that setting if needed. I initially enabled the approvals requirement to ensure that people who want to participate in this effort don't miss out.

@RichardLitt
Copy link
Contributor

I think one approval might be all that is needed. I don't know how faulty translations are, but it seems like a fairly easy think to fix if a bad one gets through.

@RichardLitt
Copy link
Contributor

I moved it to 1, with @zeke's approval on the call today. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants