Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Another release-please fix #134

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

timfish
Copy link
Contributor

@timfish timfish commented Jul 6, 2024

So it appears that the "changelog-type": "github" option actully only uses Github to determine the changelog output which results in an incorrect determination of the current release version and it also arguably has a worse changelog format.

@timfish timfish requested review from AbhiPrasad and anonrig July 6, 2024 11:33
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(╯°□°)╯︵ ┻━┻

@timfish timfish merged commit 20cdc26 into nodejs:main Jul 8, 2024
48 checks passed
@timfish timfish deleted the chore/release-please-more branch September 26, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants