fix for node 16.12 and higher #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 16.12.0 and higher replaces the `getSource` and `getFormat` hooks with a `load` hook. This has now been added, calling into the `getSource` hook in order to not duplicate its complexity. There's no need for a separate test, but eventually some mechanism of testing all supported Node.js versions and collecting the coverage data will be required, since not all lines are now covered on every Node.js version.
rochdev
approved these changes
Oct 27, 2021
| @@ -4,7 +4,7 @@ | |||
| "description": "Intercept imports in Node.js", | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "test": "c8 --check-coverage --lines 100 imhotap --runner test/runtest --files test/{hook,low-level}/*.*js", | |||
| "test": "c8 --check-coverage --lines 90 imhotap --runner test/runtest --files test/{hook,low-level}/*.*js", | |||
There was a problem hiding this comment.
Checking coverage could be moved to a separate job that checks on the merged result and still achieve 100%. Not a blocker but it would avoid coverage going down over time.
There was a problem hiding this comment.
Yeah this needs a proper setup with codecov (or similar tool) but that I can do in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 16.12.0 and higher replaces the
getSourceandgetFormathookswith a
loadhook. This has now been added, calling into thegetSourcehook in order to not duplicate its complexity.There's no need for a separate test, but eventually some mechanism of
testing all supported Node.js versions and collecting the coverage data
will be required, since not all lines are now covered on every Node.js
version.