Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

translate styles.css to stylus #100

Merged
merged 1 commit into from
Jan 22, 2015
Merged

translate styles.css to stylus #100

merged 1 commit into from
Jan 22, 2015

Conversation

Fishrock123
Copy link
Contributor

Example stylus usage. We can add {} back in or anything else if people really want,

@therebelrobot
Copy link
Contributor

-1 on removing curly braces from the source, anyone not used to stylus could be thrown off by it.

Also, I like my curlies. But I supposed I'm biased. I'm good to go either way depending on what you all think.

@zeke
Copy link
Contributor

zeke commented Jan 22, 2015

I like this. Curlies, colons, semicolons not required!

@jonathanong
Copy link

why is any css preprocessing necessary? just use CSS + autoprefixer. i'd rather make it easier for people to contribute.

@jonathanong
Copy link

also, github doesn't have syntax highlighting for stylus apparently

@Fishrock123
Copy link
Contributor Author

Huh. Yeah I'm surprised there isn't github styling for it.

I'd prefer to not write colons and semicolons at very least, but eh.

I have no preference over nested / regular styles e.g.

.app
  a
    text-align left

  ...

.content
  h1
    text-align left

  ...

vs

.app a,
.content h1 {
    text-align: left;
}

@therebelrobot
Copy link
Contributor

@Fishrock123, the syntax highlighting may be a good argument for LESS or raw CSS, though I would DEFINITELY 👎 raw CSS. That stuff is insane to work on for any type of scalable project. LESS (or regular-style Stylus, for that matter) is straight-forward enough to pick up quickly.

@zeke
Copy link
Contributor

zeke commented Jan 22, 2015

just use CSS + autoprefixer

Disagree. There's no way to write DRY, maintainable styles without variables and mixins/extends.

@zeke
Copy link
Contributor

zeke commented Jan 22, 2015

:shipit:

@therebelrobot
Copy link
Contributor

So I guess the question really is between LESS and Stylus, if github highlighting is an issue, maybe LESS may be a good fallback

@zeke
Copy link
Contributor

zeke commented Jan 22, 2015

GitHub highlighting is not an issue.

@therebelrobot
Copy link
Contributor

Kk. +1 to Stylus then. Should be good to ship.

therebelrobot added a commit that referenced this pull request Jan 22, 2015
translate styles.css to stylus
@therebelrobot therebelrobot merged commit 2b2f414 into build/gulpjs Jan 22, 2015
@snostorm
Copy link
Contributor

This is a bit late but I had, somewhere on some older commit from a week ago or so, also 👎 stylus/LESS at this stage.

While I 100% agree that things can get difficult to scale, a semi-strict component-based style guide can go a long way to keeping things DRY and reusable.

For the most part the majority of our CSS will probably be on layout of predictable sections (docs, homepage, guides, blog posts) for which the rest of the content will be markdown derived and very predictable.

Anyway, my perhaps too-late 0.02 :)

@therebelrobot
Copy link
Contributor

@snostorm if you like we can add this to the next wg agenda?

@Fishrock123 Fishrock123 deleted the build/stylus branch March 17, 2015 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants