Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute "ready-to-use" releases with generated C code #10

Closed
PiotrSikora opened this issue Nov 29, 2018 · 3 comments
Closed

Distribute "ready-to-use" releases with generated C code #10

PiotrSikora opened this issue Nov 29, 2018 · 3 comments

Comments

@PiotrSikora
Copy link

PiotrSikora commented Nov 29, 2018

Even though there is a make release target that generates C code and provides release directory:

$ tree release/
release/
├── common.gypi
├── include
│   └── llhttp.h
├── LICENSE-MIT
├── llhttp.gyp
├── README.md
└── src
    ├── api.c
    ├── http.c
    └── llhttp.c

the releases distributed on GitHub are auto-generated from the tags and include only source code.

Would you consider distributing "ready-to-use" releases with generated C code to avoid extra build-time dependencies on consumers of your library? Thanks!

@indutny
Copy link
Member

indutny commented Nov 29, 2018

Here you go: https://github.com/indutny/llhttp/releases/tag/release%2Fv1.1.0 😉

It is automated (in quite awkward way) now.

@indutny indutny closed this as completed Nov 29, 2018
@indutny
Copy link
Member

indutny commented Nov 29, 2018

As a matter of fact, all releases will live in release branch: https://github.com/indutny/llhttp/tree/release

@PiotrSikora
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants