Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: build & install shared library #84

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

pallas
Copy link
Contributor

@pallas pallas commented Jan 13, 2021

Note that the objects must be built with -fPIC now. Tested with both clang
and gcc.

Issue: #52

Note that the objects must be built with -fPIC now.  Tested with both clang
and gcc.

Issue: nodejs#52
@pallas
Copy link
Contributor Author

pallas commented Jan 29, 2021

@indutny gentle nudge

Copy link
Member

@indutny indutny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@indutny indutny merged commit aa07189 into nodejs:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants