Allow npm install to work in git clone. #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
The CI build isn't quite clean - it builds but (I got started on this as PR #107 fixes the build badge but the build is still broken.) |
hhellyer
pushed a commit
that referenced
this pull request
Aug 14, 2017
Build on FreeBSD PR-URL: #110 Reviewed-By: Howard Hellyer <hhellyer@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the travis CI build does an npm install in a git checkout.
I've tested that locally and it fails due to some of the directories already existing. This PR tries to fix that and also means that running npm install in a local git clone should work.
I think travis will build PR's automatically so I may add changes if this does not resolve the issue.