Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update travis config, handle errors properly, add TEST_LLNODE_DEBUG #144

Merged
merged 5 commits into from
Nov 30, 2017

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Nov 3, 2017

At the moment when a test times out (usually because the expected lldb output does not show up, possible due to an error), there is only a tape timeout message, as is what's happening in our Travis CI build.

This PR checks the timeout and throws an error containing the lldb output for the ease of debugging.

I've tried it on Mac and Linux with v8.9.0 and v6.11.5. I've noticed that the tests are a bit flaky in master, with random timeouts (with this patch on I can see the sent command got swallowed, it's 8 <command> instead of v8 <command> so lldb will error and the test times out). Sometimes there is a ECONNRESET on the pipe. I'll investigate that later.

@joyeecheung
Copy link
Member Author

joyeecheung commented Nov 3, 2017

The Travis builds now error instead of timing out. There is a reproduction of the "swallowed v": https://travis-ci.org/nodejs/llnode/jobs/296685259. Others seems to stuck in v8 bt.

@joyeecheung
Copy link
Member Author

joyeecheung commented Nov 7, 2017

Just noticed that since we only push the stdout lines into the buffer, the stderr lines are not available...for example on linux where process save-core is not available, the line error: Failed to save core file for process: no ObjectFile plugins were able to save a core for this process is written into stderr, not stdout.

Need to rework this a bit to show stderr lines when timing out as well.

@joyeecheung joyeecheung changed the title test: show lldb output when timing out [wip] test: show lldb output when timing out Nov 7, 2017
@joyeecheung joyeecheung force-pushed the log-error-timeout branch 3 times, most recently from fcf3962 to 2e4121e Compare November 28, 2017 15:31
@joyeecheung joyeecheung force-pushed the log-error-timeout branch 3 times, most recently from be87066 to 463135e Compare November 28, 2017 16:24
@joyeecheung joyeecheung force-pushed the log-error-timeout branch 2 times, most recently from 13bea62 to 4f7157c Compare November 28, 2017 18:08
@joyeecheung joyeecheung changed the title [wip] test: show lldb output when timing out test: update travis config, handle errors properly, add TEST_LLNODE_DEBUG Nov 28, 2017
@joyeecheung
Copy link
Member Author

Travis is now green (see https://travis-ci.org/nodejs/llnode/builds/308579054), although sometimes it fails because of #150 .

This is now ready for review, cc @cjihrig @indutny @bnoordhuis @hhellyer , thanks!

cjihrig

This comment was marked as off-topic.

@joyeecheung
Copy link
Member Author

joyeecheung commented Nov 29, 2017

@cjihrig Added a containsLine function to DRY the usage-test. The process.version comparison can be fixed in a later PR.

If there are no more reviews in 2 days I would like to land this so we can get a green Travis CI. The jenkins one probably need a bit of configuration update (last time I tried it it was using the old flow to build the plugin and failed to build it).

joyeecheung

This comment was marked as off-topic.

bnoordhuis

This comment was marked as off-topic.

@joyeecheung joyeecheung merged commit 65c577c into nodejs:master Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants