src: do not create global llscan or global llv8 #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the session is created by loading a prepared core dump, it should delete the target before quitting otherwise the process will prompt about deleting it and will hang if it does not receive an answer.
- Eliminates all references to the global llscan in the commands, only instantiate one LLScan instance in llnode.cc and pass it down to all commands. - Eliminates all references to the global llv8, store it inside the LLScan instead, because LLScan must need a valid llv8 (with postmortem metadata loaded) to function. - Only instantiate a static LLScan and a static LLV8 during plugin initialization.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Only a known flake on Travis with Node.js v9.x. Merging.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: fix hanging when testing with prepared core
When the session is created by loading a prepared core dump,
it should delete the target before quitting otherwise the
process will prompt about deleting it and will hang if it
does not receive an answer.
src: do not create global llscan or global llv8
only instantiate one LLScan instance in llnode.cc and pass it
down to all commands.
the LLScan instead, because LLScan must need a valid llv8
(with postmortem metadata loaded) to function.
initialization.
The first commit is a test fix, the second one is spinning off from #147 so llscan.o can be linked by another module.