Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run linter (clang-format) on Travis #260

Closed
wants to merge 3 commits into from
Closed

Conversation

mmarchini
Copy link
Contributor

No description provided.

@mmarchini mmarchini added the author ready PRs that have at least one approvals, no pending requests for changes, and a CI started. label Jan 25, 2019
@joyeecheung
Copy link
Member

Ping @mmarchini This needs a rebase

@codecov-io
Copy link

codecov-io commented Feb 26, 2019

Codecov Report

Merging #260 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   79.96%   79.96%           
=======================================
  Files          34       34           
  Lines        4292     4292           
=======================================
  Hits         3432     3432           
  Misses        860      860
Impacted Files Coverage Δ
src/llv8-constants.cc 85.61% <ø> (ø) ⬆️
src/llv8.cc 76.04% <ø> (ø) ⬆️
src/llnode_api.h 0% <ø> (ø) ⬆️
src/llscan.cc 55.26% <100%> (ø) ⬆️
src/llnode.cc 77.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea06ef5...bfc7d64. Read the comment docs.

@mmarchini
Copy link
Contributor Author

Done. I also moved clang-format dependency to devDependencies.

mmarchini added a commit that referenced this pull request Feb 26, 2019
PR-URL: #260
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
mmarchini added a commit that referenced this pull request Feb 26, 2019
PR-URL: #260
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
mmarchini added a commit that referenced this pull request Feb 26, 2019
PR-URL: #260
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@mmarchini
Copy link
Contributor Author

Landed in ea06ef5...85f067a

@mmarchini mmarchini closed this Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approvals, no pending requests for changes, and a CI started.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants