src: fix findrefs for context locals #295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code was too strict when hitting a context which it was unable to read Locals information: it would stop looping through the contexts even if we still had valid contexts in the queue. Changing it to loop through all context and all Locals in a context should give us a more reliable results. Also, if a given object was found in a context Locals but we're unable to read the Local name, we'll show it as ??? to indicate it's being referenced but we couldn't read its name (in case of corrupted memory, for example). Fixes: nodejs#278
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
- Coverage 79.23% 79.22% -0.01%
==========================================
Files 33 33
Lines 4229 4232 +3
==========================================
+ Hits 3351 3353 +2
- Misses 878 879 +1
Continue to review full report at Codecov.
|
joyeecheung
approved these changes
Sep 24, 2019
mmarchini
added a commit
that referenced
this pull request
Sep 25, 2019
Previous code was too strict when hitting a context which it was unable to read Locals information: it would stop looping through the contexts even if we still had valid contexts in the queue. Changing it to loop through all context and all Locals in a context should give us a more reliable results. Also, if a given object was found in a context Locals but we're unable to read the Local name, we'll show it as ??? to indicate it's being referenced but we couldn't read its name (in case of corrupted memory, for example). Fixes: #278 PR-URL: #295 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Landed in 0dbfad0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code was too strict when hitting a context which it was unable
to read Locals information: it would stop looping through the contexts
even if we still had valid contexts in the queue. Changing it to loop
through all context and all Locals in a context should give us a more
reliable results.
Also, if a given object was found in a context Locals but we're unable
to read the Local name, we'll show it as ??? to indicate it's being
referenced but we couldn't read its name (in case of corrupted memory,
for example).
Fixes: #278