Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: update UncompiledData types constants #324

Closed
wants to merge 1 commit into from
Closed

src: update UncompiledData types constants #324

wants to merge 1 commit into from

Conversation

mmarchini
Copy link
Contributor

Ref: #255

@codecov-io
Copy link

codecov-io commented Nov 8, 2019 •
edited
Loading

Codecov Report

Merging #324 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   78.87%   78.87%           
=======================================
  Files          33       33           
  Lines        4260     4260           
=======================================
  Hits         3360     3360           
  Misses        900      900
Impacted Files Coverage Δ
src/llv8-constants.cc 83.01% <ø> (ø) ⬆️
src/llv8-constants.h 100% <ø> (ø) ⬆️
src/llv8-inl.h 92.91% <100%> (ø) ⬆️
src/llnode_module.cc 89.87% <0%> (-0.64%) ⬇️
src/llv8.cc 72.82% <0%> (-0.16%) ⬇️
src/constants.cc 74.24% <0%> (+1.51%) ⬆️
src/error.h 87.5% <0%> (+12.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2afd59e...2b43e13. Read the comment docs.

@mmarchini mmarchini force-pushed the update-compiled-data branch from 66a175b to 2b43e13 Compare December 9, 2019 19:18
@mmarchini mmarchini added the author ready PRs that have at least one approvals, no pending requests for changes, and a CI started. label Dec 9, 2019
@mmarchini
Copy link
Contributor Author

cc @nodejs/llnode

mmarchini added a commit that referenced this pull request Dec 9, 2019
@mmarchini
src: update UncompiledData types constants
fde0c59 
Ref: #255

PR-URL: #324
Refs: #255
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@mmarchini
Copy link
Contributor Author

Landed in fde0c59

@mmarchini mmarchini closed this Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approvals, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmarchini @codecov-io @cjihrig