src: v12.x-compatible DescriptorArray #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 78.32% 78.64% +0.32%
==========================================
Files 33 33
Lines 4262 4290 +28
==========================================
+ Hits 3338 3374 +36
+ Misses 924 916 -8
Continue to review full report at Codecov.
|
mmarchini
force-pushed
the
v12-descriptorarray
branch
from
6238ada to
177e254
Compare
V8 changed DescriptorArray from a FixedArray to a proper HeapObject. These changes update accessors for DescriptorArray fields to make them compatible with FixedArray-like and HeapObject-like access. Ref: nodejs#255
mmarchini
force-pushed
the
v12-descriptorarray
branch
from
177e254 to
bc5641f
Compare
|
cc @nodejs/llnode |
|
Ping @nodejs/llnode, we need this for v12 support. |
|
Superseded by #330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 changed DescriptorArray from a FixedArray to a proper HeapObject.
These changes update accessors for DescriptorArray fields to make them
compatible with FixedArray-like and HeapObject-like access.
Ref: #255