test: make func source test compatbile with v12 #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarchini
added
priority
author ready
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
==========================================
- Coverage 78.32% 78.29% -0.03%
==========================================
Files 33 33
Lines 4262 4262
==========================================
- Hits 3338 3337 -1
- Misses 924 925 +1
Continue to review full report at Codecov.
|
The string stored in V8 with the function source code is different on v12. Update the regexp used in our test to match older and newer versions.
mmarchini
force-pushed
the
v12-func-source-regexp
branch
from
c7f2ab3 to
a5ae3f5
Compare
|
cc @nodejs/llnode |
|
Ping @nodejs/llnode, we need this for v12 support. |
cjihrig
approved these changes
Jan 14, 2020
mmarchini
added a commit
that referenced
this pull request
Jan 14, 2020
The string stored in V8 with the function source code is different on v12. Update the regexp used in our test to match older and newer versions. PR-URL: #326 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in fd9d2b0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string stored in V8 with the function source code is different on
v12. Update the regexp used in our test to match older and newer
versions.