meta: add policy to land PRs without approval #336
Conversation
As discussed in the 2020-02-12 Diagnostics WG Meeting and suggested in nodejs#242 (comment), change the landing policy so that Collaborators can land pull requests if it was open for three days and there were no reviews on it. Ref: nodejs/diagnostics#355
|
cc @nodejs/diagnostics @nodejs/llnode @nodejs/post-mortem please let me know if there are any objections |
| @@ -9,3 +9,6 @@ with the following differences: | |||
| - There's no minimum wait time for landing a pull request. Pull requests can | |||
| land as soon as they get approved by at least one Collaborator. | |||
| - Approval must be from Collaborators who are not authors of the change. | |||
| - If the pull request was open for three days (72 hours) without reviews, and | |||
There was a problem hiding this comment.
Not to intentionally slow llnode down any further, but what about 7 days to match the one approval clause from https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#code-reviews.
There was a problem hiding this comment.
I'm not entirely opposed to 7 days, but I don't think "to match the one approval clause from core" is a good reason to do so. I'm open to hearing other arguments to use 7 days instead of 3 though.
On a counter-argument to 7 days, if there is a bug and a PR with a fix doesn't get a review, it will now take seven days to release a fix. We could have a shorter waiting period for bug fixes, but that seems to overly complicate the policy.
There was a problem hiding this comment.
To counter your counter-argument, if there is a bug under this proposal, it will take 3 days to release a fix 😄. I guess any amount of waiting will be an arbitrary amount. I only recommended going with 7 days because that was the agreed upon answer to this exact same problem in core. At the end of the day, you're the one doing literally all of the work, and I'm not going to block this PR.
|
Keeping this open until tomorrow afternoon (PST) in case there are any objections from folks who didn't comment yet |
As discussed in the 2020-02-12 Diagnostics WG Meeting and suggested in #242 (comment), change the landing policy so that Collaborators can land pull requests if it was open for three days and there were no reviews on it. Ref: nodejs/diagnostics#355 PR-URL: #336 Refs: nodejs/diagnostics#355 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in bd3a1c7 |
Pull Request Test Coverage Report for Build 810fbce37482eb1949ea07dcbc019ce9a32ff0a8-PR-336Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
As discussed in the 2020-02-12 Diagnostics WG Meeting and suggested in
#242 (comment),
change the landing policy so that Collaborators can land pull requests
if it was open for three days and there were no reviews on it.
Ref: nodejs/diagnostics#355