Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo #343

Closed
wants to merge 1 commit into from
Closed

Typo #343

wants to merge 1 commit into from

Conversation

stefannilsson
Copy link
Contributor

No description provided.

mmarchini pushed a commit that referenced this pull request Feb 29, 2020
PR-URL: #343
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@mmarchini
Copy link
Contributor

Landed in 8bf15c0. Thank you!

@mmarchini mmarchini closed this Feb 29, 2020
@coveralls
Copy link

coveralls commented Aug 26, 2024

Pull Request Test Coverage Report for Build 29ce86695cbc2422e3f53f489465e186ea572ac4-PR-343

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 216 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+4.1%) to 78.618%

Files with Coverage Reduction New Missed Lines %
src/constants.cc 1 80.3%
src/error.h 1 87.5%
src/llv8.cc 5 70.76%
src/llnode_api.cc 8 87.5%
test/common.js 9 79.24%
src/node-inl.h 11 0.0%
src/node.h 12 20.0%
test/plugin/workqueue-test.js 13 55.17%
src/node.cc 21 37.5%
src/node-constants.cc 38 31.88%
Totals Coverage Status
Change from base Build bd3a1c7eac4c8455b7a17ff4b6c53a3234a89fe2: 4.1%
Covered Lines: 3709
Relevant Lines: 4705

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants