Update setup to latest, ignore ArrayBufferView and Arrow #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
==========================================
- Coverage 79.43% 76.58% -2.85%
==========================================
Files 34 34
Lines 5023 5023
==========================================
- Hits 3990 3847 -143
- Misses 1033 1176 +143
Continue to review full report at Codecov.
|
This was referenced Nov 16, 2021
Closed
|
@mmarchini are you going to get a chance to look at this as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the latest version of setup-node merged with the mirror branch from mmarchini's version.
https://github.com/No9/setup-node/tree/mirror
That branch has also been PR'd into the actions/setup-node upstream
actions/setup-node#360
If that isnt accepted I'm happy to open up a repo transfer request.
This PR also disables the ArrayBufferView and Arrow tests as they are currently failing.
The ArrayBufferView was identified here #375 and appears to be an upstream issue with the mappings that are generated during the V8 build. It would be great to confirm that with @nodejs/post-mortem folks though.
The Arrow test is looking for a different function comparison in the test
In 14.x it returns
Instead of 12.x
This is failing this regex
If that is expected I can update the regex to be