Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Commit

Permalink
doc: add decision
Browse files Browse the repository at this point in the history
  • Loading branch information
GeoffreyBooth committed Sep 9, 2019
1 parent 9952587 commit 623bf8b
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions doc/meetings/2019-08-28.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
## Agenda

## Announcements

*Extracted from **modules-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.

### nodejs/modules
Expand Down Expand Up @@ -68,7 +68,7 @@ JK: ESM resolver is currently a subset of CJS. Anything that is not is a bug.

WW: We added exports to both. The CJS resolve doesn't understand type:module - that's the big bug in the current implementation.

JK: After fixing this bug, we no longer face divergent specifiers.
JK: After fixing this bug, we no longer face divergent specifiers.

WW: If we start with the subsetting, we can add extension searching, then add require(ESM). That is incremental.

Expand Down Expand Up @@ -110,7 +110,7 @@ JHB: I don't think we should do that.

MB: We're at an impasse. Do you have an alternative proposal, Jordan?

JHB: No. I would like an explanation of how to write a package in Node 12 LTS that works in 8, 12 non-LTS, and 12 LTS without forcing "await import()".
JHB: No. I would like an explanation of how to write a package in Node 12 LTS that works in 8, 12 non-LTS, and 12 LTS without forcing "await import()".

GB: The only solution we have is the as-is.

Expand All @@ -127,10 +127,13 @@ MB: It's not reasonable to block unflagging without proposing an alternative sol
JHB: Lots of people have blocked things.

MB: This is different.

ACTION: TLA in CJS?

ACTION: Migration guide

ACTION: Respect `type: module` in the cjs resolver

* Revisit dot-main in exports field [#368](https://github.com/nodejs/modules/issues/368)

JK: Exports originally had a dot main as a way to drop using main as one field for both. In the very first version there was even a shorthand where if you set exports to a string that would be the main. We dropped that (a) because of the dual package thing, and (b) dot main happened to be somewhat contentious as a way of having a key that was just a dot. But now that we have additional syntax in exports such as the array fallback syntax, we basically come to a choice between two semi-bad options. (1) bring it back - exports can override main completely both for CJS and ESM. or (2) we could support that same array syntax in main but that would mean that if you want to use fallbacks for your main export you would need to drop support for all bundlers before it was introduced.
Expand Down Expand Up @@ -178,6 +181,3 @@ MB: Agreed. Enables simplicity.
* Loader Hooks [#351](https://github.com/nodejs/modules/issues/351)
* Package Exports [#341](https://github.com/nodejs/modules/issues/341)
* Proposal: Support loading package by own "name" [#306](https://github.com/nodejs/modules/issues/306)



0 comments on commit 623bf8b

Please sign in to comment.