Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Node.js Modules Team Meeting 2020-03-11 #494

Closed
mhdawson opened this issue Mar 9, 2020 · 4 comments
Closed

Node.js Modules Team Meeting 2020-03-11 #494

mhdawson opened this issue Mar 9, 2020 · 4 comments
Assignees

Comments

@mhdawson
Copy link
Member

mhdawson commented Mar 9, 2020

Time

UTC Wed 11-Mar-2020 19:00 (07:00 PM):

Timezone Date/Time
US / Pacific Wed 11-Mar-2020 12:00 (12:00 PM)
US / Mountain Wed 11-Mar-2020 13:00 (01:00 PM)
US / Central Wed 11-Mar-2020 14:00 (02:00 PM)
US / Eastern Wed 11-Mar-2020 15:00 (03:00 PM)
London Wed 11-Mar-2020 19:00 (07:00 PM)
Amsterdam Wed 11-Mar-2020 20:00 (08:00 PM)
Moscow Wed 11-Mar-2020 22:00 (10:00 PM)
Chennai Thu 12-Mar-2020 00:30 (12:30 AM)
Hangzhou Thu 12-Mar-2020 03:00 (03:00 AM)
Tokyo Thu 12-Mar-2020 04:00 (04:00 AM)
Sydney Thu 12-Mar-2020 06:00 (06:00 AM)

Or in your local time:

Links

Agenda

Extracted from modules-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/node

  • module: expose exports conditions to loaders #31303
  • WIP: Move ESM loaders to worker thread #31229
    • module: add hook for global preload code #32068

nodejs/modules

  • Chartering the Modules team #412
  • Patch/Instrument a module #339

Invited

  • Modules team: @nodejs/modules

Observers/Guests

Notes

The agenda comes from issues labelled with modules-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

@mhdawson mhdawson self-assigned this Mar 9, 2020
@GeoffreyBooth
Copy link
Member

Re nodejs/node#31303, can some of the folks in @nodejs/modules-active-members who have been less active in the codebase please take a look at the documentation added to esm.md for the resolve hook? https://github.com/jkrems/node/blob/loader-conditions/doc/api/esm.md#resolve-hook. And let me know if you understand what this new context.conditions is and how you should use it if you’re writing a hook. My concerns on that PR were about UX, but if it makes sense to everyone else (especially people who are less familiar with hooks) then I’m happy to yield to the will of the crowd.

@aduh95
Copy link

aduh95 commented Mar 11, 2020

Will #469 be discussed? Maybe an action should be taken before v14 feature freeze?

@bmeck
Copy link
Member

bmeck commented Mar 11, 2020

@aduh95 Right now I don't see a clean path towards supporting module.parent's API contract so I don't personally think we have much to talk about except what was in that thread currently

@MylesBorins
Copy link
Contributor

@aduh95 also, as ESM is still experimental, there is no feature lock for 14.x (fwiw). The only challenge would be if other parts of the codebase would need to change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants